Re: [PATCH] Add pci_save_state() to ALSA

[Takashi Iwai <tiwai@suse.de>]

At Thu, 11 Nov 2004 21:39:46 +0100,
Martin Josefsson wrote:
> 
> Hi
> 
> Some time ago, a patch was merged that removed pci_save_state() and
> pci_restore_state() from various drivers. That patch also added
> pci_restore_state() to sound/core/init.c but didn't add pci_save_state()
> anywhere.

pci_save_state() is called internally in
drivers/pci/pci-driver.c:pci_device_suspend(), so it's redundant.

> My laptop doesn't resume (gets what I assume is an ACPI timeout and
> hangs solid) without this small obvious patch.

I'm wondering how this can fix your problem...


Takashi


> Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se>
> 
> --- linux-2.6.10-rc1-bk21.orig/sound/core/init.c	2004-11-11 18:51:17.000000000 +0100
> +++ linux-2.6.10-rc1-bk21/sound/core/init.c	2004-11-11 20:57:52.000000000 +0100
> @@ -789,6 +789,8 @@ int snd_card_pci_suspend(struct pci_dev 
>  		return 0;
>  	if (card->power_state == SNDRV_CTL_POWER_D3hot)
>  		return 0;
> +	/* save the PCI config space */
> +	pci_save_state(dev);
>  	/* FIXME: correct state value? */
>  	return card->pm_suspend(card, 0);
>  }
> 
> -- 
> /Martin