Re: [PATCH RFC 0/4] firmware: Add ZSTD-compressed file support

Greg Kroah-Hartman
2021-01-27T17:12:53Z

On Wed, Jan 27, 2021 at 04:49:35PM +0100, Takashi Iwai wrote:
> Hi,
>
> it seems that ZSTD format is getting popular, and I've been asked
> about the firmware loader support. So I took a quick glance, and it
> turned out that it's fairly easy thanks to the existing ZSTD API.
> Now high time to submit something.
>
> The first patch adds a new Kconfig CONFIG_FW_LOADER_COMPRESS_ZSTD and
> the corresponding decompression function to the firmware loader code.
> For the already supported XZ-compression, CONFIG_FW_LOADER_COMPRESS_XZ
> is added to make it selectable explicitly, too.
>
> The rest three patches are for selftest: a cleanup, a fix and the
> additional support of ZSTD format.
>
> Currently, I have no idea whether any distro would use ZSTD files for
> firmware files in near future, though. That's the reason of this
> patch set being an RFC for now.

Looks sane enough to me, if we have a real user, I see no reason why to
not merge this.

thanks,

greg k-h