From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Andrew Oakley <andrew@adoakley.name>,
Chris Boyle <chris@boyle.name>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"
Date: Tue, 22 Sep 2020 17:16:18 +0200 [thread overview]
Message-ID: <s5hd02dyh8d.wl-tiwai@suse.de> (raw)
In-Reply-To: <A3819F83-2574-4BE4-824B-7464776D865E@canonical.com>
On Tue, 22 Sep 2020 17:13:05 +0200,
Kai-Heng Feng wrote:
>
>
> > On Sep 21, 2020, at 16:40, Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Tue, 15 Sep 2020 12:39:23 +0200,
> > Kai-Heng Feng wrote:
> >>
> >> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
> >>
> >> According to Realtek, volume FU works for line-in.
> >>
> >> I can confirm volume control works after device firmware is updated.
> >
> > A slight concern is what happens if you apply this change to the
> > device before the firmware update.
>
> The desktop that equips with the USB audio device hasn't released to the market yet, so I am not really worried about this.
>
> >
> > Also, after this revert, does the mixer control appear properly?
>
> Yes it does.
Alright, then let's take the patch.
Thanks for clarification.
Takashi
prev parent reply other threads:[~2020-09-22 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:39 [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control" Kai-Heng Feng
2020-09-21 8:40 ` Takashi Iwai
2020-09-22 15:13 ` Kai-Heng Feng
2020-09-22 15:16 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd02dyh8d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@adoakley.name \
--cc=chris@boyle.name \
--cc=grandmaster@al2klimov.de \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox