From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=mIr8=C7=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9B21DC4363D
	for <linux-kernel@archiver.kernel.org>; Tue, 22 Sep 2020 15:16:21 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 51E102399A
	for <linux-kernel@archiver.kernel.org>; Tue, 22 Sep 2020 15:16:21 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726703AbgIVPQU (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 22 Sep 2020 11:16:20 -0400
Received: from mx2.suse.de ([195.135.220.15]:51472 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726632AbgIVPQU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Sep 2020 11:16:20 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id C0C20ACC2;
        Tue, 22 Sep 2020 15:16:55 +0000 (UTC)
Date:   Tue, 22 Sep 2020 17:16:18 +0200
Message-ID: <s5hd02dyh8d.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
        "Alexander A. Klimov" <grandmaster@al2klimov.de>,
        Andrew Oakley <andrew@adoakley.name>,
        Chris Boyle <chris@boyle.name>,
        "moderated list:SOUND" <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"
In-Reply-To: <A3819F83-2574-4BE4-824B-7464776D865E@canonical.com>
References: <20200915103925.12777-1-kai.heng.feng@canonical.com>
        <s5hsgbbplok.wl-tiwai@suse.de>
        <A3819F83-2574-4BE4-824B-7464776D865E@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 22 Sep 2020 17:13:05 +0200,
Kai-Heng Feng wrote:
> 
> 
> > On Sep 21, 2020, at 16:40, Takashi Iwai <tiwai@suse.de> wrote:
> > 
> > On Tue, 15 Sep 2020 12:39:23 +0200,
> > Kai-Heng Feng wrote:
> >> 
> >> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
> >> 
> >> According to Realtek, volume FU works for line-in.
> >> 
> >> I can confirm volume control works after device firmware is updated.
> > 
> > A slight concern is what happens if you apply this change to the
> > device before the firmware update.
> 
> The desktop that equips with the USB audio device hasn't released to the market yet, so I am not really worried about this.
> 
> > 
> > Also, after this revert, does the mixer control appear properly?
> 
> Yes it does.

Alright, then let's take the patch.
Thanks for clarification.


Takashi