From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C76C8300A for ; Thu, 30 Apr 2020 11:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 629FD20774 for ; Thu, 30 Apr 2020 11:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbgD3L0i (ORCPT ); Thu, 30 Apr 2020 07:26:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:33608 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726413AbgD3L0i (ORCPT ); Thu, 30 Apr 2020 07:26:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 52181ACB1; Thu, 30 Apr 2020 11:26:35 +0000 (UTC) Date: Thu, 30 Apr 2020 13:26:34 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: , Jaroslav Kysela , Kailang Yang , Hui Wang , Jian-Hong Pan , Tomas Espeleta , Thomas Hebb , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , "moderated list:SOUND" , open list Subject: Re: [PATCH 3/3] ALSA: hda/realtek - Add LED class support for micmute LED In-Reply-To: <20200430083255.5093-3-kai.heng.feng@canonical.com> References: <20200430083255.5093-1-kai.heng.feng@canonical.com> <20200430083255.5093-3-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Apr 2020 10:32:53 +0200, Kai-Heng Feng wrote: > > Currently DMIC controls micmute LED via "audio mute LED trigger". > > However, unlike Dell and Lenovo platforms, HP platforms don't provide a > way to control micmute LED via ACPI, it's controlled by HDA codec > instead. > > So let's register an LED class for micmute so other subsystems like DMIC > can facilitate the codec-controlled LED. > > Signed-off-by: Kai-Heng Feng I guess this requires the Kconfig change to select CONFIG_LEDS_* or make the code conditionally built. So far the latter strategy is taken for the code in hda_generic.c. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 6f164ccddde3..82eb7624bbba 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -4103,6 +4104,24 @@ static void alc_gpio_micmute_update(struct hda_codec *codec) > spec->gen.micmute_led.led_value); > } > > +static int micmute_led_set(struct led_classdev *led_cdev, > + enum led_brightness brightness) > +{ > + struct hda_codec *codec = dev_to_hda_codec(led_cdev->dev->parent); > + struct alc_spec *spec = codec->spec; > + > + alc_update_gpio_led(codec, spec->gpio_mic_led_mask, > + spec->micmute_led_polarity, !!brightness); > + return 0; > +} > + > +static struct led_classdev micmute_led_cdev = { > + .name = "hda::micmute", > + .max_brightness = 1, > + .brightness_set_blocking = micmute_led_set, > + .default_trigger = "audio-micmute", > +}; > + > /* setup mute and mic-mute GPIO bits, add hooks appropriately */ > static void alc_fixup_hp_gpio_led(struct hda_codec *codec, > int action, > @@ -4110,6 +4129,7 @@ static void alc_fixup_hp_gpio_led(struct hda_codec *codec, > unsigned int micmute_mask) > { > struct alc_spec *spec = codec->spec; > + int err; > > alc_fixup_gpio(codec, action, mute_mask | micmute_mask); > > @@ -4122,6 +4142,11 @@ static void alc_fixup_hp_gpio_led(struct hda_codec *codec, > if (micmute_mask) { > spec->gpio_mic_led_mask = micmute_mask; > snd_hda_gen_add_micmute_led(codec, alc_gpio_micmute_update); > + > + micmute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE); > + err = devm_led_classdev_register(&codec->core.dev, &micmute_led_cdev); > + if (err) > + codec_warn(codec, "failed to register micmute LED\n"); > } > } > > -- > 2.17.1 >