From: Takashi Iwai <tiwai@suse.de>
To: " Gustavo A. R. Silva " <gustavo@embeddedor.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
"Kees Cook" <keescook@chromium.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: sparc: Mark expected switch fall-throughs
Date: Tue, 30 Jul 2019 09:39:02 +0200 [thread overview]
Message-ID: <s5hd0hsnf8p.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190730014944.GA31900@embeddedor>
On Tue, 30 Jul 2019 03:49:44 +0200,
Gustavo A. R. Silva wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: sparc64):
>
> sound/sparc/dbri.c: In function ‘reverse_bytes’:
> sound/sparc/dbri.c:582:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:583:2: note: here
> case 16:
> ^~~~
> sound/sparc/dbri.c:584:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:585:2: note: here
> case 8:
> ^~~~
> sound/sparc/dbri.c:586:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:587:2: note: here
> case 4:
> ^~~~
> sound/sparc/dbri.c:588:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:589:2: note: here
> case 2:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2019-07-30 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:49 [PATCH] ALSA: sparc: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-30 7:39 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd0hsnf8p.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox