From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELu1LOvKfUTSiShPysTfyxe4E/zVPsBFcRjDYjxu0ct0X3qBA+U8PUYtXI+j5I6rApfnn7eF ARC-Seal: i=1; a=rsa-sha256; t=1521474333; cv=none; d=google.com; s=arc-20160816; b=IvcQlUAcYN+pkqg50W3ZwlwCjGOOQ+XffPM49/RUQhemvfhDMUFAzk1FwrCD+lYmQE dCmReO8lSM7vq/gp7ZQnekWXYXyu2YMK6fjT/Q5N7fhA8vhqzGU672PdjdrqEUfTZ6LW moPkjy5U7ihFHNyB1ira2xD5/0IkvRVQVmou55uKdGi+IFse7x06lPTJ8EsUKVqDzQkd a534yTlC4H4hJTiswcLbhu0m5CjObxyyol8rfF/EhA6Yis1WponkCWjbHhI9OyXykfU7 /VwBUYJElz55pz6BSxGsydYzdy73puSSqaRebTtXQkdmoXnMCM/G2ji8PCzUKNk8TOaC Awyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:arc-authentication-results; bh=XymXbNITTSe4hc3xkFMCG1WmvXoIQyVADfbJy78bbys=; b=QrmWiPToh8ITAhcAdRmjl0rpL0cX5qAJ/MJJ6k4jdOmlD5iUhgzercLKXBlLoFK4Rh LYUgTi6bUD5z9U8GcLYiD1OopV98kLBBbb/vzjWtN9Af/Bbrl6SMa/3bzeWrGr38v0n0 fy6sacmh3Zhuv/LP3A4sc8lNU/G5QKLn4XsWk7Cppu9nQpdxS+pInO6rYQXZoF3ZeieM SeaASS7jkFIOdpzZK+HjVkGNzLsqlNAgp2HRomYEzZmMv0olnK58zgknCIirssr6JnYj NClje4gGraLSlRB4xVfUtDTyaOj9tFKD7RUqCJ1P5/Z3C3lDtuHiJAkZIQirfKiOVlQJ LPxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Authentication-Results: mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Date: Mon, 19 Mar 2018 16:45:29 +0100 Message-ID: From: Takashi Iwai To: "Kirill Marinushkin" Cc: "Greg Kroah-Hartman" , , "Ruslan Bilovol" , "Mark Brown" , "Thomas Gleixner" , "Felipe Balbi" , "Philippe Ombredanne" , "Jaroslav Kysela" , Subject: Re: [PATCH] ALSA: usb-audio: Fix parsing descriptor of UAC2 processing unit In-Reply-To: References: <20180319061108.24178-1-k.marinushkin@gmail.com> <20180319074019.GA30688@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1595345312154569888?= X-GMAIL-MSGID: =?utf-8?q?1595381469976789094?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, 19 Mar 2018 08:47:49 +0100, Takashi Iwai wrote: > > On Mon, 19 Mar 2018 08:40:19 +0100, > Greg Kroah-Hartman wrote: > > > > On Mon, Mar 19, 2018 at 07:11:08AM +0100, Kirill Marinushkin wrote: > > > Currently, the offsets in the UAC2 processing unit descriptor are > > > calculated incorrectly. It causes an issue when connecting the device which > > > provides such a feature: > > > > > > ~~~~ > > > [84126.724420] usb 1-1.3.1: invalid Processing Unit descriptor (id 18) > > > ~~~~ > > > > > > After this patch is applied, the UAC2 processing unit inits w/o this error. > > > > > > Fixes: 5e1ddb481776 ("UAPI: (Scripted) Disintegrate include/linux/usb") > > > Signed-off-by: Kirill Marinushkin > > > Cc: Mark Brown > > > Cc: Jaroslav Kysela > > > Cc: Takashi Iwai > > > Cc: Thomas Gleixner > > > Cc: Felipe Balbi > > > Cc: Philippe Ombredanne > > > Cc: Greg Kroah-Hartman > > > Cc: Ruslan Bilovol > > > Cc: linux-kernel@vger.kernel.org > > > Cc: alsa-devel@alsa-project.org > > > --- > > > include/uapi/linux/usb/audio.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Cc: stable > > perhaps? > > Yes, it deserves. But I'd need to double-check the UAC2 > specification. It's interesting that such a basic thing hasn't hit > until now. Maybe just because it's a fairly minor feature. ... and the patch looks correct, after confirming the UAC2 spec. Now I applied it, with a minor correction of Fixes tag, which actually was introduced by 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0"), and adding Cc to stable. Thanks! Takashi