From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbbE0GSg (ORCPT ); Wed, 27 May 2015 02:18:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41476 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbbE0GSd (ORCPT ); Wed, 27 May 2015 02:18:33 -0400 Date: Wed, 27 May 2015 08:18:31 +0200 Message-ID: From: Takashi Iwai To: "Jie, Yang" Cc: Sudip Mukherjee , "broonie@kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "Girdwood, Liam R" , "Zhang, Vivian" Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint In-Reply-To: References: <1432646037-23803-1-git-send-email-yang.jie@intel.com> <1432646037-23803-3-git-send-email-yang.jie@intel.com> <20150527044955.GB3096@sudip-PC> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 27 May 2015 05:38:01 +0000, Jie, Yang wrote: > > > -----Original Message----- > > From: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com] > > Sent: Wednesday, May 27, 2015 12:50 PM > > To: Jie, Yang > > Cc: tiwai@suse.de; broonie@kernel.org; alsa-devel@alsa-project.org; linux- > > kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > > footprint > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which > > > can save about 9KB memory size for reducing memory footprint purpose. > > > --- > > missing Signed-off-by. > > Thanks for pointing out. > > Signed-off-by: Jie Yang > > Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: ================================================================ > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > + bool "Reduced Memory Footprint Support" > + default n > + help > + Say 'Y' to enable Reduced Memory Footprint Support, which may > + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. ================================================================ And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool "Sound proc file" if EXPERT depends on PROC_FS .... Takashi