From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755738AbaJINiv (ORCPT ); Thu, 9 Oct 2014 09:38:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42214 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbaJINio (ORCPT ); Thu, 9 Oct 2014 09:38:44 -0400 Date: Thu, 09 Oct 2014 15:38:41 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: au88x0: pr_* replaced with dev_* In-Reply-To: <1412847397-4292-2-git-send-email-sudipm.mukherjee@gmail.com> References: <1412847397-4292-1-git-send-email-sudipm.mukherjee@gmail.com> <1412847397-4292-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 9 Oct 2014 15:06:37 +0530, Sudip Mukherjee wrote: > > pr_* macros replaced with dev_* as they are more preffered over pr_*. > each file which had pr_* was reviewed manually and replaced with dev_*. > here we have actually used the reference of the vortex which was added > to some functions in the previous patch of this series. > > Signed-off-by: Sudip Mukherjee > --- > sound/pci/au88x0/au88x0.c | 26 +++++----- > sound/pci/au88x0/au88x0_a3d.c | 15 +++--- > sound/pci/au88x0/au88x0_core.c | 103 ++++++++++++++++++++++----------------- > sound/pci/au88x0/au88x0_eq.c | 3 +- > sound/pci/au88x0/au88x0_game.c | 3 +- > sound/pci/au88x0/au88x0_mpu401.c | 2 +- > sound/pci/au88x0/au88x0_pcm.c | 7 +-- > sound/pci/au88x0/au88x0_synth.c | 17 ++++--- > 8 files changed, 98 insertions(+), 78 deletions(-) > > diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c > index 21ce31f..ea66cee 100644 > --- a/sound/pci/au88x0/au88x0.c > +++ b/sound/pci/au88x0/au88x0.c > @@ -48,10 +48,10 @@ static void vortex_fix_latency(struct pci_dev *vortex) > { > int rc; > if (!(rc = pci_write_config_byte(vortex, 0x40, 0xff))) { > - pr_info( CARD_NAME > + dev_info(&vortex->dev, CARD_NAME > ": vortex latency is 0xff\n"); Omit the superfluous prefix when converting to dev_info() & co. Other than that, looks good to me. thanks, Takashi