From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027Ab2DEOdg (ORCPT ); Thu, 5 Apr 2012 10:33:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33718 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518Ab2DEOdf (ORCPT ); Thu, 5 Apr 2012 10:33:35 -0400 Date: Thu, 05 Apr 2012 16:33:34 +0200 Message-ID: From: Takashi Iwai To: Michael Karcher Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] sound/pci/hda: CX20549 doesn't need pin_amp_workaround. In-Reply-To: <1333632635.4159.15.camel@localhost> References: <1333632635.4159.15.camel@localhost> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 05 Apr 2012 15:30:35 +0200, Michael Karcher wrote: > > CX20549 (ctx5045) doesn't accept data on index 1 for output pins, > as shown in the following hda-var transaction: > > $ hda-verb /dev/snd/hwC0D0 0x10 set_amp_gain 0xb126 > nid = 0x10, verb = 0x300, param = 0xb126 > value = 0x0 > $ hda-verb /dev/snd/hwC0D0 0x10 get_amp_gain 0x8001 > nid = 0x10, verb = 0xb00, param = 0x8001 > value = 0x0 OK, it's good to know. Could you fix it in the corresponding part in patch_conexant_auto(), too? Takashi > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 8d7a977..3ab7b25 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -1087,7 +1087,6 @@ static int patch_cxt5045(struct hda_codec *codec) > if (!spec) > return -ENOMEM; > codec->spec = spec; > - codec->pin_amp_workaround = 1; > > spec->multiout.max_channels = 2; > spec->multiout.num_dacs = ARRAY_SIZE(cxt5045_dac_nids); > -- > 1.7.9.1 > > >