From: Takashi Iwai <tiwai@suse.de>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Thomas Meyer <thomas@m3y3r.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: hda-intel: no soundcard with current linus' git tree
Date: Thu, 18 Oct 2007 07:57:27 +0200 [thread overview]
Message-ID: <s5hd4vdc6d4.wl%tiwai@suse.de> (raw)
In-Reply-To: <200710180353.08638.maximlevitsky@gmail.com>
At Thu, 18 Oct 2007 03:53:08 +0200,
Maxim Levitsky wrote:
>
> From 0824b077b75c19253b45c5a455775c331acd54ee Mon Sep 17 00:00:00 2001
> From: Maxim Levitsky <maximlevitsky@gmail.com>
> Date: Thu, 18 Oct 2007 03:35:37 +0200
> Subject: [PATCH] [HDA] [STAC] Since there is now a master volume control,
> don't call the headphone output "Master", it isn't strictly correct anyway
I thought stac925x has no volume knob, so "Master" should be still
applied for this codec?
Takashi
>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> ---
> pci/hda/patch_sigmatel.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
> index 6dffa54..7f157a6 100644
> --- a/pci/hda/patch_sigmatel.c
> +++ b/pci/hda/patch_sigmatel.c
> @@ -1907,12 +1907,7 @@ static int stac92xx_auto_create_hp_ctls(struct hda_codec *codec,
> return err;
> }
> if (spec->multiout.hp_nid) {
> - const char *pfx;
> - if (old_num_dacs == spec->multiout.num_dacs)
> - pfx = "Master";
> - else
> - pfx = "Headphone";
> - err = create_controls(spec, pfx, spec->multiout.hp_nid, 3);
> + err = create_controls(spec, "Headphone", spec->multiout.hp_nid, 3);
> if (err < 0)
> return err;
> }
> --
> 1.5.3.4
>
next prev parent reply other threads:[~2007-10-18 6:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 22:18 hda-intel: no soundcard with current linus' git tree Thomas Meyer
2007-10-17 2:47 ` Maxim Levitsky
2007-10-17 8:42 ` Takashi Iwai
2007-10-17 18:17 ` Thomas Meyer
2007-10-18 1:51 ` Maxim Levitsky
2007-10-18 1:53 ` Maxim Levitsky
2007-10-18 5:57 ` Takashi Iwai [this message]
2007-10-18 14:21 ` Maxim Levitsky
2007-10-18 13:49 ` Takashi Iwai
2007-10-18 15:24 ` Maxim Levitsky
2007-10-18 14:47 ` Takashi Iwai
2007-10-21 15:42 ` Thomas Meyer
2007-10-18 2:35 ` Jeff Garzik
2007-10-18 3:36 ` Maxim Levitsky
2007-10-18 3:38 ` Jeff Garzik
2007-10-18 4:10 ` Maxim Levitsky
2007-10-18 4:24 ` Jeff Garzik
2007-10-18 6:02 ` Takashi Iwai
2007-10-18 8:49 ` Jan-Simon Möller
2007-10-18 8:11 ` [alsa-devel] " Takashi Iwai
2007-10-18 11:50 ` Jan-Simon Möller
2007-10-18 15:05 ` Jan-Simon Möller
2007-10-18 14:39 ` Takashi Iwai
2007-10-18 16:19 ` Jan-Simon Möller
2007-10-19 5:05 ` Takashi Iwai
2007-10-19 10:46 ` Jan-Simon Möller
2007-10-19 10:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd4vdc6d4.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox