From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A413DC433F5
	for <linux-kernel@archiver.kernel.org>; Fri, 18 Mar 2022 08:19:25 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233702AbiCRIUl (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 18 Mar 2022 04:20:41 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37412 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230352AbiCRIUi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Mar 2022 04:20:38 -0400
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37F322290
        for <linux-kernel@vger.kernel.org>; Fri, 18 Mar 2022 01:19:20 -0700 (PDT)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id E3DBD210EA;
        Fri, 18 Mar 2022 08:19:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1647591558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=IjCmVVbStmeSrUy8iam013ODXCyxxLPZ4pMuaBBq+B8=;
        b=Ydq868Uun7pWUhB3UQ/UHADPMKp1aQk7+M+d5dLeIxW/utcL0+5VYCES2Mrv11whL1QjVi
        bMUrOM2NbN7CEmXiFR4jaI1ykJ8p1F83GwccUhunmZEy7zURSoTT6kEZbQdQROuemK5NQD
        KHANlFA/FFHHRCiDNeZyyla/hMTayq4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1647591558;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=IjCmVVbStmeSrUy8iam013ODXCyxxLPZ4pMuaBBq+B8=;
        b=n5ygpjoNuP1rZLAc04mps10ejc5nX2j/0LEc4T4BAfNMHEO3yGf1QA7Q0OIAKdYnm5At94
        7MlSPgh3PL/J4RAg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 57121A3B89;
        Fri, 18 Mar 2022 08:19:18 +0000 (UTC)
Date:   Fri, 18 Mar 2022 09:19:18 +0100
Message-ID: <s5hee2z4qrd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Hui Wang <hui.wang@canonical.com>,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
        Hans de Goede <hdegoede@redhat.com>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9
In-Reply-To: <20220317221134.566358-1-kai.heng.feng@canonical.com>
References: <20220317221134.566358-1-kai.heng.feng@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 17 Mar 2022 23:11:33 +0100,
Kai-Heng Feng wrote:
> 
> Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> breaks mute and micmute LEDs because it changed the LED quirk from
> ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
> here.
> 
> Also reorder the chain of quirks to ensure LED quirk is the last one
> being applied.
> 
> Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, applied now.


Takashi