From: Takashi Iwai <tiwai@suse.de>
To: " Gustavo A. R. Silva " <gustavo@embeddedor.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
"Kees Cook" <keescook@chromium.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through
Date: Tue, 30 Jul 2019 09:36:41 +0200 [thread overview]
Message-ID: <s5hef28nfcm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190729205454.GA5084@embeddedor>
On Mon, 29 Jul 2019 22:54:54 +0200,
Gustavo A. R. Silva wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: m68k):
>
> sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]: => 1449:24
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Update code so switch and case statements are at the same indent.
Applied, thanks.
Takashi
prev parent reply other threads:[~2019-07-30 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 20:54 [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 21:48 ` Kees Cook
2019-07-30 7:05 ` Geert Uytterhoeven
2019-07-30 7:36 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hef28nfcm.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=geert@linux-m68k.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox