From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F29C5ACCC for ; Thu, 18 Oct 2018 13:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3C2220645 for ; Thu, 18 Oct 2018 13:55:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3C2220645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728165AbeJRV5A (ORCPT ); Thu, 18 Oct 2018 17:57:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:39140 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726695AbeJRV5A (ORCPT ); Thu, 18 Oct 2018 17:57:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E3FC7AFA6; Thu, 18 Oct 2018 13:55:50 +0000 (UTC) Date: Thu, 18 Oct 2018 15:55:49 +0200 Message-ID: From: Takashi Iwai To: Philipp K Cc: Lukas Bulwahn , Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [sound/i2c/cs8427] Fix int to char conversion In-Reply-To: References: <20181018103303.30226-1-philipp97kl@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Oct 2018 15:47:55 +0200, Philipp K wrote: > > [1 ] > > On Thu, Oct 18, 2018, 15:46 Takashi Iwai wrote: > > On Thu, 18 Oct 2018 12:33:02 +0200, > Philipp Klocke wrote: > > > > Compiling with clang yields the following warning: > > > > sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int' > > to 'char' changes value from 160 to -96 [-Wconstant-conversion] > >     data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF; > >             ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Because CS8427_REG_AUTOINC is defined as 128, it is too big for a > > char field. > > So change data from char to unsigned char, that it can hold the value. > > > > This patch does not change the generated code. > > > > Signed-off-by: Philipp Klocke > > Applied, thanks. > > But at the next time, please put the relevant subsystem MLs to Cc, > > Oh sorry I forgot that. Just used the get maintainer script. > > and use the proper subject prefix (depending on the subsystem). > > What would have been the correct prefix in this case? In this particular case, I modified the subject to ALSA: i2c/cs8427: Fix int to char conversion The subject prefix usage is case-by-case. Better to look at the commits of the relevant file and just follow the convention in general. thanks, Takashi