From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755321AbdLLNKO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 08:10:14 -0500
Received: from mx2.suse.de ([195.135.220.15]:44382 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753611AbdLLNKL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 08:10:11 -0500
Date: Tue, 12 Dec 2017 14:10:09 +0100
Message-ID: <s5hefo0jdn2.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Charles Keepax" <ckeepax@opensource.cirrus.com>
Cc: "Steven Eckhoff" <steven.eckhoff.opensource@gmail.com>,
        <alsa-devel@alsa-project.org>, "Liam Girdwood" <lgirdwood@gmail.com>,
        "MarkBrown" <broonie@kernel.org>, "Jaroslav Kysela" <perex@perex.cz>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC
In-Reply-To: <20171212130401.nugvjnko6x3c3apn@localhost.localdomain>
References: <20171211195403.3irxp7g3n326ub3g@localhost.localdomain>
        <20171212130401.nugvjnko6x3c3apn@localhost.localdomain>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 12 Dec 2017 14:04:01 +0100,
Charles Keepax wrote:
> 
> On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> > Currently there is no support for the TSCS42xx audio CODEC.
> > 
> > Add support for it.
> > 
> > v5 attempts to address all issues raised in the previous reviews.
> > 
> > Thank you to everyone who has invested their time reviewing these
> > patches.
> > 
> > Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
> > ---
> > +int bytes_tlv_callback(struct snd_kcontrol *kcontrol, int op_flag,
> > +	unsigned int size, unsigned int __user *tlv)
> > +{
> > +	struct tscs_dsp_ctl *ctl =
> > +		(struct tscs_dsp_ctl *)kcontrol->private_value;
> > +	struct soc_bytes_ext *params = &ctl->bytes_ext;
> > +	unsigned int count = size < params->max ? size : params->max;
> > +	int ret = -ENXIO;
> > +
> > +	switch (op_flag) {
> > +	case SNDRV_CTL_TLV_OP_READ:
> > +		if (params->get)
> > +			ret = params->get(kcontrol, tlv, count);
> > +		break;
> > +	case SNDRV_CTL_TLV_OP_WRITE:
> > +		if (params->put)
> > +			ret = params->put(kcontrol, tlv, count);
> > +		break;
> > +	}
> > +	return ret;
> > +}
> 
> Should this function be removed, I am assuming it is a hang over
> from the earlier TLV implementation?

Yes, and bytes_ext_info() is also missing static.


Takashi