public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	kay.sievers@vrfy.org, rdunlap@xenotime.net,
	mchehab@infradead.org, perex@perex.cz, hjlipp@web.de,
	davem@davemloft.net, w.sang@pengutronix.de
Subject: Re: [PATCH] Remove references to /etc/modprobe.conf
Date: Fri, 16 Mar 2012 15:51:23 +0100	[thread overview]
Message-ID: <s5hehsstx90.wl%tiwai@suse.de> (raw)
In-Reply-To: <1331908876-1268-1-git-send-email-lucas.demarchi@profusion.mobi>

At Fri, 16 Mar 2012 11:41:16 -0300,
Lucas De Marchi wrote:
> 
> Usage of /etc/modprobe.conf file was deprecated by module-init-tools and
> is no longer parsed by new kmod tool. References to this file are
> replaced in Documentation, comments and Kconfig according to the
> context.
> 
> There are also some references to the old /etc/modules.conf from 2.4
> kernels that are being removed.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>

It's nice to correct the document, but the change like

-  /etc/modprobe.conf to ensure that the aoe module is loaded when
+  /etc/modprobe.d/aoe.conf to ensure that the aoe module is loaded when

might be misleading since it looks as if the fixed config file name
must be used.

Also, the config file name should be with a number prefix.  At least,
it's recommended so in the recent distros to determine the loading
order.  However, which number to be used depends on pretty much on the
distribution.

So, from both points, it'd be better to mention that it's an example
file name.


thanks,

Takashi

  reply	other threads:[~2012-03-16 14:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 14:41 [PATCH] Remove references to /etc/modprobe.conf Lucas De Marchi
2012-03-16 14:51 ` Takashi Iwai [this message]
2012-03-16 15:51   ` Lucas De Marchi
2012-03-16 15:57     ` Takashi Iwai
2012-03-17  6:14       ` [PATCHES v2 2/2] " Lucas De Marchi
2012-03-20 17:45         ` Lucas De Marchi
2012-03-21 11:03           ` Takashi Iwai
2012-03-21 16:21           ` Randy Dunlap
2012-03-16 14:54 ` [PATCH] " Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hehsstx90.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=davem@davemloft.net \
    --cc=hjlipp@web.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=mchehab@infradead.org \
    --cc=perex@perex.cz \
    --cc=rdunlap@xenotime.net \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox