From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755204Ab1ALRCR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 12 Jan 2011 12:02:17 -0500
Received: from cantor2.suse.de ([195.135.220.15]:44978 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752214Ab1ALRCN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 12 Jan 2011 12:02:13 -0500
Date: Wed, 12 Jan 2011 18:02:10 +0100
Message-ID: <s5hei8i838t.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Hanno =?UTF-8?B?QsO2Y2s=?= <hanno@hboeck.de>, alsa-devel@alsa-project.org,
        perex@perex.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: constify functions in ac97
In-Reply-To: <AANLkTi=SJpxh5h774shB+MW=xM8cyfunyJYO0deU9mCT@mail.gmail.com>
References: <201101121203.55901.hanno@hboeck.de>
	<AANLkTi=SJpxh5h774shB+MW=xM8cyfunyJYO0deU9mCT@mail.gmail.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 12 Jan 2011 14:44:07 +0200,
Alexey Dobriyan wrote:
> 
> On Wed, Jan 12, 2011 at 1:03 PM, Hanno Böck <hanno@hboeck.de> wrote:
> >  struct snd_ac97_build_ops {
> > -       int (*build_3d) (struct snd_ac97 *ac97);
> > -       int (*build_specific) (struct snd_ac97 *ac97);
> > -       int (*build_spdif) (struct snd_ac97 *ac97);
> > -       int (*build_post_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_3d) (struct snd_ac97 *ac97);
> > +       int (* const build_specific) (struct snd_ac97 *ac97);
> > +       int (* const build_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_post_spdif) (struct snd_ac97 *ac97);
> >  #ifdef CONFIG_PM
> > -       void (*suspend) (struct snd_ac97 *ac97);
> > -       void (*resume) (struct snd_ac97 *ac97);
> > +       void (* const suspend) (struct snd_ac97 *ac97);
> > +       void (* const resume) (struct snd_ac97 *ac97);
> >  #endif
> > -       void (*update_jacks) (struct snd_ac97 *ac97);   /* for jack-sharing */
> > +       /* for jack-sharing */
> > +       void (* const update_jacks) (struct snd_ac97 *ac97);
> 
> Can we please not do this.
> 
> You made whole ops structure RO, this is enough.

Yes.  Hanno, could you fix and resubmit?


thanks,

Takashi