From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262386AbVEMO21 (ORCPT ); Fri, 13 May 2005 10:28:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262385AbVEMO21 (ORCPT ); Fri, 13 May 2005 10:28:27 -0400 Received: from ns.suse.de ([195.135.220.2]:11987 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S262379AbVEMO2Z (ORCPT ); Fri, 13 May 2005 10:28:25 -0400 Date: Fri, 13 May 2005 16:28:20 +0200 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [2.6 patch] sound/pci/: make code static In-Reply-To: <20050513140050.GE16549@stusta.de> References: <20050513140050.GE16549@stusta.de> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 13 May 2005 16:00:50 +0200, Adrian Bunk wrote: > > This patch makes needlessly global code static. > > Signed-off-by: Adrian Bunk > > --- > > sound/pci/ac97/ac97_codec.c | 9 ++++++--- > sound/pci/ac97/ac97_local.h | 3 --- These ones are kept global intentionally so that any ac97 patch may call them in future. Let's keep as they are. > sound/pci/ca0106/ca0106_proc.c | 2 +- > sound/pci/hda/hda_codec.c | 6 ++++-- I fixed them on ALSA tree. Thanks! Takashi