From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A386C48BE5 for ; Wed, 16 Jun 2021 06:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5A64613BF for ; Wed, 16 Jun 2021 06:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231689AbhFPGxI (ORCPT ); Wed, 16 Jun 2021 02:53:08 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:55708 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFPGxG (ORCPT ); Wed, 16 Jun 2021 02:53:06 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D6D6A1FD47; Wed, 16 Jun 2021 06:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623826259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DVo8Z1hPdxqSxUn+mu8aduZxE8KaKDVvpZcxB4cNmtE=; b=kY52ZIeHIRqtq9k6vcryyqlQ5U06056YwupY2sn1DpsU1Cs1Ncx9CKbWkrywWk+DcC7hh0 +f3AxHM92SL4FDVhTwVOXzalDhKFb4T8xdahTyv/odslN1pozSoTZJANDWHVnMrPiwYySB sa//RCwxqjR+PzG05CB0CH89mlAyaGc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623826259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DVo8Z1hPdxqSxUn+mu8aduZxE8KaKDVvpZcxB4cNmtE=; b=JmHTL/9ONj5cSKMjxqft6Fb7xrqaQjBcg2jaAwSYMhgviMj/+JdA6mJA6ArN2yvwSqWg8E 4qlPB6G2p4gWaADQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id BBF3EA3B8F; Wed, 16 Jun 2021 06:50:59 +0000 (UTC) Date: Wed, 16 Jun 2021 08:50:59 +0200 Message-ID: From: Takashi Iwai To: Yang Yingliang Cc: , , , , Subject: Re: [PATCH -next] ALSA: fm801: Fix missing pci_release_regions() on error in snd_fm801_create() In-Reply-To: <20210616025507.2120103-1-yangyingliang@huawei.com> References: <20210616025507.2120103-1-yangyingliang@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Jun 2021 04:55:07 +0200, Yang Yingliang wrote: > > Fix the missing pci_release_regions() before return > from snd_fm801_create() in the error handling case. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang pci_regions() is manated in pcim_release(), hence you don't need to call it explicitly. thanks, Takashi