From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753570AbdHWIfE (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Aug 2017 04:35:04 -0400
Received: from mx2.suse.de ([195.135.220.15]:52331 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1753433AbdHWIfD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Aug 2017 04:35:03 -0400
Date: Wed, 23 Aug 2017 10:35:00 +0200
Message-ID: <s5hfucir8az.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Ingo Molnar <mingo@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] ALSA: pcm: Adjust 11 checks for null pointers
In-Reply-To: <fc79090d-7ed8-9083-4726-29769e0ef8d8@users.sourceforge.net>
References: <b8c9e41b-a47e-1d99-3d1a-5d39772e4b54@users.sourceforge.net>
        <s5h378isw2d.wl-tiwai@suse.de>
        <800d7aa6-d8f2-cbf5-caaa-7e4006976e68@users.sourceforge.net>
        <fc79090d-7ed8-9083-4726-29769e0ef8d8@users.sourceforge.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 23 Aug 2017 10:25:49 +0200,
SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 23 Aug 2017 09:28:00 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The script “checkpatch.pl” pointed information out like the following.
> 
> Comparison to NULL could be written …
> 
> Thus fix the affected source code places.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Converting only these alone doesn't give any big merit.  Another patch
in the series fixed the style if ((err = xxx)), so it's fine, though.

checkpatch is no bible, after all.


thanks,

Takashi