From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081Ab1DUSYo (ORCPT ); Thu, 21 Apr 2011 14:24:44 -0400 Received: from cantor.suse.de ([195.135.220.2]:59402 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829Ab1DUSYn (ORCPT ); Thu, 21 Apr 2011 14:24:43 -0400 Date: Thu, 21 Apr 2011 20:24:42 +0200 Message-ID: From: Takashi Iwai To: Chris Ball Cc: Aries Lee , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 21 Apr 2011 13:36:03 -0400, Chris Ball wrote: > > Hi Takashi, > > On Thu, Apr 21 2011, Takashi Iwai wrote: > >> I don't like overwriting ops here -- it's too magical, and now we have > >> to maintain the ops table in two places. A quirk seems justified here, > >> even though we're trying to reduce them in general. > > > > Well, I also used quirk bit in my very first version I worked for > > 2.6.32 kernel. But when I looked at 2.6.39, quirks are almost full -- > > only the last one bit is left for bit 31. So I didn't want to finish > > it :) > > > >> Can anyone find a better solution? > > > > One way would be to copy the ops table itself in struct sdhci_host > > instead of keeping the ops table pointer. Then you can overwrite only > > the specific op in each probe_slot callback. > > I think I'd rather not touch ops at all and keep the code simple -- > if you don't mind, please post a version with quirks, and I'll work > on freeing up a few bits. OK, I'll send shortly. Takashi