* [PATCH v2] ALSA: emu10k1: Stop using iommu_present()
@ 2022-04-05 13:27 Robin Murphy
2022-04-05 16:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Robin Murphy @ 2022-04-05 13:27 UTC (permalink / raw)
To: perex, tiwai; +Cc: iommu, alsa-devel, linux-kernel
iommu_get_domain_for_dev() is already perfectly happy to return NULL
if the given device has no IOMMU. Drop the unnecessary check in favour
of just handling that condition appropriately.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
v2: Get "!domain" condition right
sound/pci/emu10k1/emu10k1_main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
index 86cc1ca025e4..3880f359e688 100644
--- a/sound/pci/emu10k1/emu10k1_main.c
+++ b/sound/pci/emu10k1/emu10k1_main.c
@@ -1751,11 +1751,8 @@ static void snd_emu10k1_detect_iommu(struct snd_emu10k1 *emu)
emu->iommu_workaround = false;
- if (!iommu_present(emu->card->dev->bus))
- return;
-
domain = iommu_get_domain_for_dev(emu->card->dev);
- if (domain && domain->type == IOMMU_DOMAIN_IDENTITY)
+ if (!domain || domain->type == IOMMU_DOMAIN_IDENTITY)
return;
dev_notice(emu->card->dev,
--
2.28.0.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-05 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-05 13:27 [PATCH v2] ALSA: emu10k1: Stop using iommu_present() Robin Murphy
2022-04-05 16:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox