From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C61C433EF for ; Fri, 14 Jan 2022 16:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243123AbiANQIy (ORCPT ); Fri, 14 Jan 2022 11:08:54 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:56694 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243103AbiANQIx (ORCPT ); Fri, 14 Jan 2022 11:08:53 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3687A21999; Fri, 14 Jan 2022 16:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1642176532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z5gwVJadRBLwIZdzE+LehRr5OzKg/JfjH5sJdL3H2KA=; b=0grys/TwZymsKKsPX2tBQm3a5HWjUqj76u+aLQ379byvY7S2IdzFtLGy6JyBX9SWULiO33 2S05z6r6Zd7F9XVibVnCpFAqc2MZWgzD+jTX7tX9J0baDuG6rVBmjpRnEaz+2qB3wJNJUH YLW0yuv507SRxy5kMM5ARdmrZkCa9DA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1642176532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z5gwVJadRBLwIZdzE+LehRr5OzKg/JfjH5sJdL3H2KA=; b=lNkT1yBJc4N/H51OYmtgc77hvgJOAsLsKZ5TPsIkGYjLlGsjAg//pWIRE64VsMTKuZtucA o5dlc6cJN4z1r6Dg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B8FB3A3B81; Fri, 14 Jan 2022 16:08:51 +0000 (UTC) Date: Fri, 14 Jan 2022 17:08:51 +0100 Message-ID: From: Takashi Iwai To: Alexander Sergeyev Cc: Jaroslav Kysela , Takashi Iwai , Jeremy Szu , Werner Sembach , Hui Wang , Cameron Berkenpas , Kailang Yang , Sami Loone , Elia Devito , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: fix speakers and micmute on HP 855 G8 In-Reply-To: <20220113210930.dtryx4ifjsmb33lz@localhost.localdomain> References: <20220113210930.dtryx4ifjsmb33lz@localhost.localdomain> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Jan 2022 22:09:30 +0100, Alexander Sergeyev wrote: > > There are several PCI ids associated with HP EliteBook 855 G8 Notebook > PC. Commit 0e68c4b11f1e6 ("ALSA: hda/realtek: fix mute/micmute LEDs for > HP 855 G8") covers 0x103c:0x8896, while this commit covers 0x103c:0x8895 > which needs some additional work on top of the quirk from 0e68c4b11f1e6. > > Note that the device can boot up with working speakers and micmute LED > without this patch, but the success rate would be quite low (order of > 16 working boots across 709 boots) at least for the built-in drivers > scenario. This also means that there are some timing issues during early > boot and this patch is a workaround. > > Changes are tested on v5.16. Speakers and headphones are consistenly > working, as well as mute/micmute LEDs and the internal microphone. > > Signed-off-by: Alexander Sergeyev > --- The change looks OK, but it doesn't apply to the latest tree. Could you rebase it with either sound.git tree for-linus branch or the latest Linus tree, and resubmit? thanks, Takashi