From: Takashi Iwai <tiwai@suse.de>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, kai.heng.feng@canonical.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 2/2] sound: usb: fix use after free in usb_audio_disconnect
Date: Tue, 09 Mar 2021 07:43:34 +0100 [thread overview]
Message-ID: <s5hh7lk3jzd.wl-tiwai@suse.de> (raw)
In-Reply-To: <16da19126ff461e5e64a9aec648cce28fb8ed73e.1615242183.git.paskripkin@gmail.com>
On Mon, 08 Mar 2021 23:30:57 +0100,
Pavel Skripkin wrote:
>
> The problem was in wrong "if" placement. chip->quirk_type is freed
> in snd_card_free_when_closed(), but inside if statement it's accesed.
>
> Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()"
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2021-03-09 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 22:29 [PATCH next 0/2] fixes for sound: usb: Pavel Skripkin
2021-03-08 22:30 ` [PATCH next 1/2] sound: usb: fix NULL ptr dereference in usb_audio_probe Pavel Skripkin
2021-03-09 6:37 ` Takashi Iwai
2021-03-08 22:30 ` [PATCH next 2/2] sound: usb: fix use after free in usb_audio_disconnect Pavel Skripkin
2021-03-09 6:43 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh7lk3jzd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox