From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13251C4649B for ; Fri, 5 Jul 2019 10:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6A462082F for ; Fri, 5 Jul 2019 10:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728335AbfGEKMz (ORCPT ); Fri, 5 Jul 2019 06:12:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:39950 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726005AbfGEKMz (ORCPT ); Fri, 5 Jul 2019 06:12:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E4A6CAF96; Fri, 5 Jul 2019 10:12:50 +0000 (UTC) Date: Fri, 05 Jul 2019 12:12:50 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: , Jaroslav Kysela , "Takashi Iwai" , , Subject: Re: [PATCH] ALSA: cs4281: remove redundant assignment to variable val and remove a goto In-Reply-To: <20190705095704.26050-1-colin.king@canonical.com> References: <20190705095704.26050-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Jul 2019 11:57:04 +0200, Colin King wrote: > > From: Colin Ian King > > The variable val is being assigned with a value that is never > read and it is being updated later with a new value. The > assignment is redundant and can be removed. Also remove a > goto statement and a label and replace with a break statement. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thanks. Takashi