From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4DCCC2D0C3 for ; Mon, 30 Dec 2019 07:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B07F020718 for ; Mon, 30 Dec 2019 07:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfL3HFd (ORCPT ); Mon, 30 Dec 2019 02:05:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:46302 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfL3HFd (ORCPT ); Mon, 30 Dec 2019 02:05:33 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 999F3ACEC; Mon, 30 Dec 2019 07:05:31 +0000 (UTC) Date: Mon, 30 Dec 2019 08:05:31 +0100 Message-ID: From: Takashi Iwai To: Chris Chiu Cc: perex@perex.cz, tiwai@suse.com, kailang@realtek.com, hui.wang@canonical.com, tomas.espeleta@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux@endlessm.com, Jian-Hong Pan Subject: Re: [PATCH v3] ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC In-Reply-To: <20191230031118.95076-1-chiu@endlessm.com> References: <20191230031118.95076-1-chiu@endlessm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Dec 2019 04:11:18 +0100, Chris Chiu wrote: > > ASUS reported that there's an bass speaker in addition to internal > speaker and it uses DAC 0x02. It was not enabled in the commit > 436e25505f34 ("ALSA: hda/realtek - Enable internal speaker of ASUS > UX431FLC") which only enables the amplifier and the front speaker. > This commit enables the bass speaker on top of the aforementioned > work to improve the acoustic experience. > > Signed-off-by: Chris Chiu > Signed-off-by: Jian-Hong Pan Applied now. Thanks. Takashi