From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0808FC4646D for ; Wed, 15 Aug 2018 12:15:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B243D215E5 for ; Wed, 15 Aug 2018 12:15:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B243D215E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729232AbeHOPHG (ORCPT ); Wed, 15 Aug 2018 11:07:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:39872 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727141AbeHOPHG (ORCPT ); Wed, 15 Aug 2018 11:07:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EEA76ACFD; Wed, 15 Aug 2018 12:15:08 +0000 (UTC) Date: Wed, 15 Aug 2018 14:15:07 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, Eric Dumazet , "David S . Miller" , linux-kernel@vger.kernel.org, Michal Kubecek , Jiri Bohac Subject: Re: [PATCH 4.4.y] tcp: Fix missing range_truesize enlargement in the backport In-Reply-To: <20180815111121.GA17583@kroah.com> References: <20180815095846.7734-1-tiwai@suse.de> <20180815111121.GA17583@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Aug 2018 13:11:21 +0200, Greg Kroah-Hartman wrote: > > On Wed, Aug 15, 2018 at 11:58:46AM +0200, Takashi Iwai wrote: > > The 4.4.y stable backport dc6ae4dffd65 for the upstream commit > > 3d4bf93ac120 ("tcp: detect malicious patterns in > > tcp_collapse_ofo_queue()") missed a line that enlarges the > > range_truesize value, which broke the whole check. > > > > Fixes: dc6ae4dffd65 ("tcp: detect malicious patterns in tcp_collapse_ofo_queue()") > > Signed-off-by: Takashi Iwai > > --- > > > > Greg, this is a fix-up specific to 4.4.y stable backport that had a > > slightly different form from upstream fix. I haven't looked at the > > older trees, but 4.9.y and later took the upstream fix as is, so this > > patch isn't needed for them. > > > > The patch hasn't been tested with the real test case, though; let me > > know if the current code is intended. Thanks! > > Hm, I did the initial backport, and then Eric showed what I got wrong > and fixed that up, so being still wrong is not inconceivable at all :) > > Have you tried testing this with the reproducer? That might be the best > verification here. If your testing proves to be good, I'll gladly take > this patch, thanks! No, I haven't tested it, just followed from the thread in the past (and hope that our QA team will test that sooner or later :) Will let you know if we find any issues in the current tree. And, if the current code works as intended, it's great, of course. thanks, Takashi