From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbeCZOnk (ORCPT ); Mon, 26 Mar 2018 10:43:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:47093 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbeCZOnj (ORCPT ); Mon, 26 Mar 2018 10:43:39 -0400 Date: Mon, 26 Mar 2018 16:43:37 +0200 Message-ID: From: Takashi Iwai To: "Robert Rosengren" Cc: , "Jaroslav Kysela" , "Robert Rosengren" , Subject: Re: [PATCH] ALSA: aloop: Mark paused device as inactive In-Reply-To: <20180326052449.3618-1-robertr@axis.com> References: <20180326052449.3618-1-robertr@axis.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Mar 2018 07:24:49 +0200, Robert Rosengren wrote: > > Show paused ALSA aloop device as inactive, i.e. the control > "PCM Slave Active" set as false. Notification sent upon state change. > > This makes it possible for client capturing from aloop device to know if > data is expected. Without it the client expects data even if playback > is paused. > > Signed-off-by: Robert Rosengren The code change looks good, but just to be sure: you've submitted from the address robert.rosengren@axis.com that is different from the sign-off robertr@axis.com. Is this intentional? The former is recorded as the author in git history. thanks, Takashi