From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbdJERTI (ORCPT ); Thu, 5 Oct 2017 13:19:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:35420 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751216AbdJERTH (ORCPT ); Thu, 5 Oct 2017 13:19:07 -0400 Date: Thu, 05 Oct 2017 19:19:06 +0200 Message-ID: From: Takashi Iwai To: Kees Cook Cc: LKML , moderated for non-subscribers , Bhumika Goyal , Mark Brown , Thomas Gleixner , Jaroslav Kysela Subject: Re: [PATCH] ALSA: sh: aica: Convert timers to use timer_setup() In-Reply-To: References: <20171005005336.GA23796@beast> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Oct 2017 19:17:16 +0200, Kees Cook wrote: > > On Wed, Oct 4, 2017 at 11:22 PM, Takashi Iwai wrote: > > On Thu, 05 Oct 2017 02:53:36 +0200, > > Kees Cook wrote: > >> > >> In preparation for unconditionally passing the struct timer_list pointer to > >> all timer callbacks, switch to using the new timer_setup() and from_timer() > >> to pass the timer pointer explicitly. This requires adding a pointer to > >> hold the timer's target substream, as there won't be a way to pass this in > >> the future. > >> > >> Cc: Jaroslav Kysela > >> Cc: Takashi Iwai > >> Cc: Bhumika Goyal > >> Cc: Mark Brown > >> Cc: alsa-devel@alsa-project.org > >> Cc: Thomas Gleixner > >> Signed-off-by: Kees Cook > >> --- > >> This requires commit 686fef928bba ("timer: Prepare to change timer > >> callback argument type") in v4.14-rc3, but should be otherwise > >> stand-alone. > > > > The conversions look straightforward, so I'm going to apply it (and > > other two you posted). But now I wonder why only three were chosen. > > Will you keep working on the rest usages in sound/*, or would you > > expect us doing the rest? > > Hi, thanks for applying them! > > I'm working my way through the "non-trivial" changes first. I have a > coccinelle script that will do a mass-conversion of the common cases. > It's possible that those changes cover the other usages in sound/* or > that I haven't made my way through the others yet (it's a very long > list). I wouldn't object to other people helping with the conversions, > of course. :) OK, scripting is a better way, then I'd save my time and wait until you get more systematic coverage, then :) thanks, Takashi