From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753157AbdICOgu (ORCPT <rfc822;w@1wt.eu>);
        Sun, 3 Sep 2017 10:36:50 -0400
Received: from mx2.suse.de ([195.135.220.15]:36936 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752948AbdICOgt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 3 Sep 2017 10:36:49 -0400
Date: Sun, 03 Sep 2017 16:36:48 +0200
Message-ID: <s5hingzvofz.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Wang YanQing <udknight@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe
In-Reply-To: <20170903141122.GA2848@udknight>
References: <20170903141122.GA2848@udknight>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 03 Sep 2017 16:11:22 +0200,
Wang YanQing wrote:
> 
> When hda_codec_driver_probe meet error and return failure, we need
> to free resource with patch_ops.free, or we will get resource leak.

No, the codec driver is responsible to free resources in its error
path.


thanks,

Takashi