From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262379AbUK0CG5 (ORCPT ); Fri, 26 Nov 2004 21:06:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262404AbUK0CGW (ORCPT ); Fri, 26 Nov 2004 21:06:22 -0500 Received: from zeus.kernel.org ([204.152.189.113]:10692 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S262379AbUKZTiN (ORCPT ); Fri, 26 Nov 2004 14:38:13 -0500 Date: Thu, 25 Nov 2004 16:20:30 +0100 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [2.6 patch] ALSA ISA drivers: misc cleanups In-Reply-To: <20041124232758.GP19873@stusta.de> References: <20041124232758.GP19873@stusta.de> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 25 Nov 2004 00:27:58 +0100, Adrian Bunk wrote: > > The patch below makes cleanups under sound/isa/ including: > - make needlessly global code static > - ad1816a/ad1816a_lib.c: much code was unused starting with the > global function snd_ad1816a_timer I prefer disabling this to removal (in case somone wants to add the timer function). > - removed EXPORT_SYMBOL's: > - cs423x/cs4231_lib.c: snd_cs4231_outm > - es1688/es1688_lib.c: snd_es1688_mixer_read > > Please review this patch. Otherwise looks fine. Applied it to ALSA tree. Thanks! Takashi