From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266687AbUGLM6R (ORCPT ); Mon, 12 Jul 2004 08:58:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266813AbUGLM6Q (ORCPT ); Mon, 12 Jul 2004 08:58:16 -0400 Received: from cantor.suse.de ([195.135.220.2]:52180 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S266687AbUGLM6P (ORCPT ); Mon, 12 Jul 2004 08:58:15 -0400 Date: Mon, 12 Jul 2004 14:53:37 +0200 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: paul@linuxaudiosystems.com, thomas@undata.org, perex@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] ALSA rme9652/hdsp: remove inlines In-Reply-To: <20040711102637.GA4701@fs.tum.de> References: <20040711102637.GA4701@fs.tum.de> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 11 Jul 2004 12:26:37 +0200, Adrian Bunk wrote: > > The patch below removes all inlines from hdsp.c. As a side effect, it > showed that snd_hdsp_9652_disable_mixer() is completely unused, and it's > therefore also removed in the patch. > > > An alternative approach to removing the inlines would be to keep all > inlines that are _really_ required and reorder the functions in the file > accordingly. Just removing inline should be fine, since they are all no time-critical functions. I'll apply it to ALSA tree. thanks, -- Takashi Iwai ALSA Developer - www.alsa-project.org