From: Takashi Iwai <tiwai@suse.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] More MODULE_ALIAS work, and documentation updates.
Date: Wed, 10 Sep 2003 15:38:22 +0200 [thread overview]
Message-ID: <s5hiso0vk4x.wl@alsa2.suse.de> (raw)
In-Reply-To: <20030910075240.E128A2C74F@lists.samba.org>
Hi,
At Wed, 10 Sep 2003 17:52:11 +1000,
Rusty Russell wrote:
>
> Hi all,
>
> I know this is something of a megapatch, but I'm trying to get
> all the module aliases people expect into the modules before 2.6.0. I
> got most of these by reading the documentation: review appreciated.
>
> If noone NAKs, I'll send to Linus in a couple of days. I'm
> sure you can think of other aliases which should be added, too.
the ALSA part looks fine for me.
and it looks now much much cleaner. thanks!
well, very subtle things:
for sound-service-?-1 and sound-service-?-8, only 0 is available,
and other numbers don't exist.
so, the definition in sound/core/seq/oss/seq_oss.c can be like
MODULE_ALIAS("sound-service-0-" __stringify(SNDRV_MINOR_OSS_SEQUENCER));
MODULE_ALIAS("sound-service-0-" __stringify(SNDRV_MINOR_OSS_MUSIC));
but it's harmless to use MODULE_ALIAS_SNDRV_MINOR() as you did... :)
--
Takashi Iwai <tiwai@suse.de> SuSE Linux AG - www.suse.de
ALSA Developer ALSA Project - www.alsa-project.org
prev parent reply other threads:[~2003-09-10 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-10 7:52 [PATCH] More MODULE_ALIAS work, and documentation updates Rusty Russell
2003-09-10 13:38 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hiso0vk4x.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox