From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758774AbaHZOVM (ORCPT ); Tue, 26 Aug 2014 10:21:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45978 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758206AbaHZOVK (ORCPT ); Tue, 26 Aug 2014 10:21:10 -0400 Date: Tue, 26 Aug 2014 16:21:07 +0200 Message-ID: From: Takashi Iwai To: Jarkko Nikula Cc: alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [alsa-devel] [PATCH 1/2] regmap: cache: Fix regcache_sync_block for non-autoincrementing devices In-Reply-To: <1409061793-10495-2-git-send-email-jarkko.nikula@linux.intel.com> References: <1409061793-10495-1-git-send-email-jarkko.nikula@linux.intel.com> <1409061793-10495-2-git-send-email-jarkko.nikula@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Aug 2014 17:03:12 +0300, Jarkko Nikula wrote: > > Commit 75a5f89f635c ("regmap: cache: Write consecutive registers in a single > block write") expected that autoincrementing writes are supported if > hardware has a register format which can support raw writes. > > This is not necessarily true and thus for instance rbtree sync can fail when > there is need to sync multiple consecutive registers but block write to > device fails due not supported autoincrementing writes. > > Fix this by spliting raw block sync to series of single register writes for > devices that don't support autoincrementing writes. Wouldn't it suffice to correct regmap_can_raw_write() to return false if map->use_single_rw is set? Takashi > > Signed-off-by: Jarkko Nikula > --- > I noticed this with Realtek RT5642 audio codec which didn't resume properly > since first block write having more data than for single register failed to > not acknowledged I2C write during regcache_sync(). Chip acknowledges device > address, register address and two data bytes for its word size registers but > next data byte is not which then causes aborted I2C transfer and aborted > register sync. > --- > drivers/base/regmap/regcache.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c > index 29b4128da0b0..54707e586ac8 100644 > --- a/drivers/base/regmap/regcache.c > +++ b/drivers/base/regmap/regcache.c > @@ -629,6 +629,7 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data, > { > size_t val_bytes = map->format.val_bytes; > int ret, count; > + unsigned int i; > > if (*data == NULL) > return 0; > @@ -640,7 +641,18 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data, > > map->cache_bypass = 1; > > - ret = _regmap_raw_write(map, base, *data, count * val_bytes); > + if (!map->use_single_rw) { > + ret = _regmap_raw_write(map, base, *data, count * val_bytes); > + } else { > + for (i = 0; i < count; i++) { > + ret = _regmap_raw_write(map, > + base + (i * map->reg_stride), > + *data + (i * val_bytes), > + val_bytes); > + if (ret != 0) > + break; > + } > + } > > map->cache_bypass = 0; > > -- > 2.1.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >