From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B8BC433FE for ; Fri, 18 Mar 2022 13:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236555AbiCRNNH (ORCPT ); Fri, 18 Mar 2022 09:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236570AbiCRNNA (ORCPT ); Fri, 18 Mar 2022 09:13:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 050EF2D107F; Fri, 18 Mar 2022 06:11:40 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9CB0721101; Fri, 18 Mar 2022 13:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1647609099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cW4GmCFqe34avbpqimA0TTsN/w6TwfFxsEo9h7KeItk=; b=qE8Zz5X34e+PRkIddr8HgEYpmJxVptivB+gEQnAgbyl8PX60LW9pxpt0ueHpdgMpjbh7VQ Jq7/jjYvrMDJuJYZpI3lVB9wJ/ZFPvmcPTPB7ZZ0QOkvp4AjWVPPji6RJf4PidXtwJVPft j5I4scMZlAWVOTlzsAqe0Xilja0C2ng= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1647609099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cW4GmCFqe34avbpqimA0TTsN/w6TwfFxsEo9h7KeItk=; b=/+b3nmgcJO67MJ9g5KdlJshi3R07E7lKvU6xrfoPpo9mB0Snqtr1ZPAVsSx5KNlQgmtK5e wdIG4zRerTo7mCDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 49282A3B83; Fri, 18 Mar 2022 13:11:39 +0000 (UTC) Date: Fri, 18 Mar 2022 14:11:39 +0100 Message-ID: From: Takashi Iwai To: =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= Cc: Takashi Iwai , linux-input@vger.kernel.org, Peter Hutterer , Benjamin Tissoires , Jiri Kosina , stable@vger.kernel.org, regressions@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [REGRESSION] Right touchpad button disabled on Dell 7750 In-Reply-To: <20220318130740.GA33535@elementary> References: <20220318130740.GA33535@elementary> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Mar 2022 14:07:40 +0100, José Expósito wrote: > > Hi Takashi, > > Thanks for reporting the regression here. > > On Fri, Mar 18, 2022 at 12:42:31PM +0100, Takashi Iwai wrote: > > Hi, > > > > we received a bug report about the regression of the touchpad on Dell > > 7750 laptop, the right touchpad button is disabled on recent kernels: > > https://bugzilla.suse.com/show_bug.cgi?id=1197243 > > > > Note that it's a physical button, not a virtual clickpad button. > > > > The regression seems introduced by the upstream commit > > 37ef4c19b4c659926ce65a7ac709ceaefb211c40 ("Input: clear > > BTN_RIGHT/MIDDLE on buttonpads") that was backported to stable 5.16.x > > kernel. > > > > The device is managed by hid-multitouch driver, and the further > > investigation revealed that it's rather an incorrectly recognized > > buttonpad property; namely, ID_DG_BUTTONTYPE reports it being 0 = > > clickable touchpad although it's not. I built a test kernel to ignore > > this check and it was confirmed to make the right button working again > > by the reporter. > > > > Is this check really correct in general? Or do we need some > > device-specific quirk? > > A couple of days ago another user with the same laptop (Dell Precision > 7550 or 7750) emailed me to report the issue and I sent him a patch for > testing. > > I he confirms that the patch works, I'll send it to the mailing list. > > I believe that your analysis of the regression is correct and I think > that we'd need to add a quirk for the device. > > In case you want to have a look to the patch, I added it to this > libinput [1] report. Great, I'll try to build and ask the reporter to test with the patch. Thanks! Takashi > > Thanks, > Jose > > [1] https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/726#note_1303623 >