From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9803AC433DB for ; Mon, 15 Mar 2021 15:42:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A8EF64E74 for ; Mon, 15 Mar 2021 15:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231633AbhCOPl7 (ORCPT ); Mon, 15 Mar 2021 11:41:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:33346 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232210AbhCOPlr (ORCPT ); Mon, 15 Mar 2021 11:41:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 15AC5AC75; Mon, 15 Mar 2021 15:41:46 +0000 (UTC) Date: Mon, 15 Mar 2021 16:41:46 +0100 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Cc: , , Stefan Binding , Takashi Iwai , Subject: Re: [PATCH v1 1/4] ALSA: hda/cirrus: Add error handling into CS8409 I2C functions In-Reply-To: References: <20210313113410.90088-1-vitalyr@opensource.cirrus.com> <20210313113410.90088-2-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Mar 2021 16:37:32 +0100, Vitaly Rodionov wrote: > > >> @@ -1881,13 +1896,15 @@ static void cs8409_jack_unsol_event(struct hda_codec *codec, unsigned int res) > >> reg_hs_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1124, 1); > >> reg_ts_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); > >> - /* Clear interrupts */ > >> + /* Clear interrupts, by reading interrupt status registers */ > >> cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1b7b, 1); > >> - cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1308, 1); > >> - cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); > > Why those two calls are removed? > This 2 call are redundant as we already did read these 2 registers in > a code few lines above. OK, then please either split the patch to address this or mention the change briefly in the commit log. thanks, Takashi