The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Nicola Lunghi" <nick83ola@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Allison Randal" <allison@lohutok.net>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Jussi Laako" <jussi@sonarnerd.net>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: usb-audio: fix Line6 Helix audio format rates
Date: Sun, 07 Jul 2019 11:27:20 +0200	[thread overview]
Message-ID: <s5hlfxajitj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190707082734.25829-1-nick83ola@gmail.com>

On Sun, 07 Jul 2019 10:27:34 +0200,
Nicola Lunghi wrote:
> @@ -294,7 +321,7 @@ static int parse_audio_format_rates_v2v3(struct snd_usb_audio *chip,
>  {
>  	struct usb_device *dev = chip->dev;
>  	unsigned char tmp[2], *data;
> -	int nr_triplets, data_size, ret = 0;
> +	int nr_triplets, data_size, ret, ret_l6 = 0;

This caused a compile warning:
  sound/usb/format.c: In function ‘parse_audio_format_rates_v2v3’:
  sound/usb/format.c:337:30: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    int nr_triplets, data_size, ret, ret_l6 = 0;
                                ^~~
				
So I applied with a fix, keeping ret = 0 while dropping the
superfluous zero initialization for ret_l6.


thanks,

Takashi

      reply	other threads:[~2019-07-07  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-07  8:27 [PATCH v2] ALSA: usb-audio: fix Line6 Helix audio format rates Nicola Lunghi
2019-07-07  9:27 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlfxajitj.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=allison@lohutok.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jussi@sonarnerd.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick83ola@gmail.com \
    --cc=perex@perex.cz \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox