From: Takashi Iwai <tiwai@suse.de>
To: "Zhouyang Jia" <jiazhouyang09@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
"Bhumika Goyal" <bhumirks@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: sonicvibes: add error handling for snd_ctl_add
Date: Mon, 11 Jun 2018 15:26:02 +0200 [thread overview]
Message-ID: <s5hlgblbgk5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1528704521-34060-1-git-send-email-jiazhouyang09@gmail.com>
On Mon, 11 Jun 2018 10:08:40 +0200,
Zhouyang Jia wrote:
>
> When snd_ctl_add fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling snd_ctl_add.
>
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
I postpone this one because the change won't give anything as is
although this change itself is correct. If you look at the code
closely, the caller of snd_sonicvibes_create_gameport() ignores the
return value.
So we need to fix two places.
thanks,
Takashi
next prev parent reply other threads:[~2018-06-11 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 8:08 [PATCH] ALSA: sonicvibes: add error handling for snd_ctl_add Zhouyang Jia
2018-06-11 13:26 ` Takashi Iwai [this message]
2018-06-14 11:22 ` [PATCH v2] " Zhouyang Jia
2018-06-14 11:30 ` Takashi Iwai
2018-06-14 11:41 ` [PATCH v3] " Zhouyang Jia
2018-06-14 16:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlgblbgk5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=jiazhouyang09@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox