From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753128AbdICOeI (ORCPT ); Sun, 3 Sep 2017 10:34:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:36815 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752965AbdICOeH (ORCPT ); Sun, 3 Sep 2017 10:34:07 -0400 Date: Sun, 03 Sep 2017 16:34:05 +0200 Message-ID: From: Takashi Iwai To: Wang YanQing Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, libin.yang@linux.intel.com Subject: Re: [PATCH] ALSA: hda: Fix regression of hdmi eld control created based on invalid pcm In-Reply-To: <20170903131849.GA2278@udknight> References: <20170903131849.GA2278@udknight> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Sep 2017 15:18:49 +0200, Wang YanQing wrote: > > Commit fb087eaaef72 ("ALSA: hda - hdmi eld control created based on pcm") > forget to filter out invalid pcm numbers, if there is only one invalid pcm > number, then this issue causes we create eld control for invalid pcm silently, > but when there are more than one invalid pcm numbers, then this issue bring > probe error looks like below dmesg: > " > kernel: [ 1.647283] snd_hda_intel 0000:00:03.0: bound 0000:00:02.0 (ops 0xc2967540) > kernel: [ 1.651192] snd_hda_intel 0000:00:03.0: Too many HDMI devices > kernel: [ 1.651195] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y > kernel: [ 1.651197] snd_hda_intel 0000:00:03.0: Too many HDMI devices > kernel: [ 1.651199] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y > kernel: [ 1.651201] snd_hda_intel 0000:00:03.0: Too many HDMI devices > kernel: [ 1.651203] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y > kernel: [ 1.651676] snd_hda_intel 0000:00:03.0: control 3:0:0:ELD:0 is already present > kernel: [ 1.651787] snd_hda_codec_hdmi: probe of hdaudioC0D0 failed with error -16 > " > > This patch add invalid pcm number filter before calling hdmi_create_eld_ctl. > > Fixes: fb087eaaef72 ("ALSA: hda - hdmi eld control created based on pcm") > Signed-off-by: Wang YanQing Applied, thanks. Takashi