From: Takashi Iwai <tiwai@suse.de>
To: "Sudip Mukherjee" <sudipm.mukherjee@gmail.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hdsp: fix memory leak
Date: Fri, 11 Sep 2015 17:35:44 +0200 [thread overview]
Message-ID: <s5hlhcd6ka7.wl-tiwai@suse.de> (raw)
In-Reply-To: <1441978838-18803-1-git-send-email-sudipm.mukherjee@gmail.com>
On Fri, 11 Sep 2015 15:40:38 +0200,
Sudip Mukherjee wrote:
>
> If the size of the firmware is less than expected size then we are
> exiting with the error code but we missed releasing the firmware.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Applied, thanks.
Takashi
> ---
> sound/pci/rme9652/hdsp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
> index 9bba275..2875b4f 100644
> --- a/sound/pci/rme9652/hdsp.c
> +++ b/sound/pci/rme9652/hdsp.c
> @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp)
> dev_err(hdsp->card->dev,
> "too short firmware size %d (expected %d)\n",
> (int)fw->size, HDSP_FIRMWARE_SIZE);
> + release_firmware(fw);
> return -EINVAL;
> }
>
> --
> 1.9.1
>
>
prev parent reply other threads:[~2015-09-11 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 13:40 [PATCH] ALSA: hdsp: fix memory leak Sudip Mukherjee
2015-09-11 15:35 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlhcd6ka7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox