From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbbIKPfr (ORCPT ); Fri, 11 Sep 2015 11:35:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:42979 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbbIKPfq (ORCPT ); Fri, 11 Sep 2015 11:35:46 -0400 Date: Fri, 11 Sep 2015 17:35:44 +0200 Message-ID: From: Takashi Iwai To: "Sudip Mukherjee" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: hdsp: fix memory leak In-Reply-To: <1441978838-18803-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1441978838-18803-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Sep 2015 15:40:38 +0200, Sudip Mukherjee wrote: > > If the size of the firmware is less than expected size then we are > exiting with the error code but we missed releasing the firmware. > > Signed-off-by: Sudip Mukherjee Applied, thanks. Takashi > --- > sound/pci/rme9652/hdsp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c > index 9bba275..2875b4f 100644 > --- a/sound/pci/rme9652/hdsp.c > +++ b/sound/pci/rme9652/hdsp.c > @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp) > dev_err(hdsp->card->dev, > "too short firmware size %d (expected %d)\n", > (int)fw->size, HDSP_FIRMWARE_SIZE); > + release_firmware(fw); > return -EINVAL; > } > > -- > 1.9.1 > >