From: Takashi Iwai <tiwai@suse.de>
To: bainonline@gmail.com
Cc: perex@suse.cz, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] [ALSA] Add first generation macbook subsystem ID
Date: Tue, 17 Apr 2007 11:59:12 +0200 [thread overview]
Message-ID: <s5hlkgrcoen.wl%tiwai@suse.de> (raw)
In-Reply-To: <46244dbb.7672bd23.37b9.00c5@mx.google.com>
At Tue, 17 Apr 2007 10:01:47 +0530,
bainonline@gmail.com wrote:
>
> From: Abhijit Bhopatkar <bainonline@gmail.com>
>
> First generation MacBooks were getting ignored by sigmatel drivers
> and wrongly being identified as MACMINI. This patch makes them
> identify as MACBOOK.
>
> Signed-off-by: Abhijit Bhopatkar <bainonline@gmail.com>
This actually doesn't change behavior at all (both mac mini and mac
book use the same pin configs), but it's still nice to add ID if any
specific fix would be needed in future.
Applied to ALSA tree now. Thanks.
Takashi
> ---
> sound/pci/hda/patch_sigmatel.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index c94291b..cb99df5 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1905,6 +1905,9 @@ static int patch_stac922x(struct hda_codec *codec)
> */
> printk(KERN_INFO "hda_codec: STAC922x, Apple subsys_id=%x\n", codec->subsystem_id);
> switch (codec->subsystem_id) {
> + case 0x106b0a00: /* MacBook First generatoin */
> + spec->board_config = STAC_MACBOOK;
> + break;
> case 0x106b0200: /* MacBook Pro first generation */
> spec->board_config = STAC_MACBOOK_PRO_V1;
> break;
> --
> 1.4.4.2
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2007-04-17 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 4:31 [PATCH] [ALSA] Add first generation macbook subsystem ID bainonline
2007-04-17 9:59 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlkgrcoen.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bainonline@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox