public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Jaroslav Kysela <perex@suse.cz>,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [Alsa-devel] [PATCH] Fix a memory leak in pdaudiocf
Date: Mon, 15 May 2006 10:39:18 +0200	[thread overview]
Message-ID: <s5hlkt3wukp.wl%tiwai@suse.de> (raw)
In-Reply-To: <200605132344.25862.jesper.juhl@gmail.com>

At Sat, 13 May 2006 23:44:25 +0200,
Jesper Juhl wrote:
> 
> There's a potential memory leak in 
> sound/pcmcia/pdaudiocf/pdaudiocf.c::pdacf_config()
> 
> If we leave via one of the *failed: labels we may leak 'parse', so add a 
> kfree(parse) to the end of the function and also make sure to set 'parse' 
> to NULL after the kfree() call a little further up so we don't do a 
> double-free of the pointer if we hit one of the *failed: labels after the 
> first kfree().
> 
> Since I don't have the hardware I can't test the patch beyond making sure 
> it compiles cleanly, but I feel pretty confident that it is correct.
> 
> Please consider for inclusion.

This bug was already fixed in a different way on ALSA HG repo.

thanks,

Takashi

      reply	other threads:[~2006-05-15  8:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-13 21:44 [PATCH] Fix a memory leak in pdaudiocf Jesper Juhl
2006-05-15  8:39 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlkt3wukp.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox