From: Takashi Iwai <tiwai@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller
Date: Tue, 03 Aug 2021 16:05:43 +0200 [thread overview]
Message-ID: <s5hmtpyvd1k.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210803122839.7143-1-colin.king@canonical.com>
On Tue, 03 Aug 2021 14:28:39 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array names_to_check on the stack but instead it
> static. Makes the object code smaller by 56 bytes. Also clean
> up checkpatch warning by adding extra const for names_to_check
> and pointer s.
>
> Before:
> text data bss dec hex filename
> 103512 34380 0 137892 21aa4 ./sound/usb/mixer.o
>
> After:
> text data bss dec hex filename
> 103264 34572 0 137836 21a6c ./sound/usb/mixer.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: Clean up checkpatch warning on const-ness for names_to_check.
> Add extra const to clean up build warning on pointer s.
Thanks, applied.
Takashi
prev parent reply other threads:[~2021-08-03 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 12:28 [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller Colin King
2021-08-03 14:05 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmtpyvd1k.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox