Re: [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller

Takashi Iwai
2021-08-03T14:05:46Z

On Tue, 03 Aug 2021 14:28:39 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array names_to_check on the stack but instead it
> static. Makes the object code smaller by 56 bytes. Also clean
> up checkpatch warning by adding extra const for names_to_check
> and pointer s.
>
> Before:
> text data bss dec hex filename
> 103512 34380 0 137892 21aa4 ./sound/usb/mixer.o
>
> After:
> text data bss dec hex filename
> 103264 34572 0 137836 21a6c ./sound/usb/mixer.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: Clean up checkpatch warning on const-ness for names_to_check.
> Add extra const to clean up build warning on pointer s.

Thanks, applied.

Takashi