From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E12BAC433DB
	for <linux-kernel@archiver.kernel.org>; Thu, 11 Mar 2021 14:07:18 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 809E364E59
	for <linux-kernel@archiver.kernel.org>; Thu, 11 Mar 2021 14:07:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233681AbhCKOGq (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 11 Mar 2021 09:06:46 -0500
Received: from mx2.suse.de ([195.135.220.15]:59204 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233809AbhCKOGY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Mar 2021 09:06:24 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay1.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id B679AAB8C;
        Thu, 11 Mar 2021 14:06:23 +0000 (UTC)
Date:   Thu, 11 Mar 2021 15:06:20 +0100
Message-ID: <s5hmtv9vl7n.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries.
In-Reply-To: <CAHp75VcxRK=NsHXRtN8k8wrE8YSyNDqyTLb37TP4ojO_CW5ceg@mail.gmail.com>
References: <20210311132741.80989-1-andriy.shevchenko@linux.intel.com>
        <s5hpn05vmhm.wl-tiwai@suse.de>
        <CAHp75VcxRK=NsHXRtN8k8wrE8YSyNDqyTLb37TP4ojO_CW5ceg@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 11 Mar 2021 15:02:16 +0100,
Andy Shevchenko wrote:
> 
> On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Thu, 11 Mar 2021 14:27:41 +0100,
> > Andy Shevchenko wrote:
> > >
> > > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> > > No functional change implied.
> >
> > I'd love to apply this kind of cleanups (and I do sometimes
> > partially), but practically seen, this may make the stable backporting
> > significantly harder because many quirk patches are backported to the
> > very old LTS kernels.  So, unless any specific reason (e.g. some
> > entries doubled or wrongly applied) is given, I'd avoid this full
> > plastic surgery.
> 
> Can we ask people to follow the ordering before patches were applied?

Yeah, I should apply more strict check in my side in future, too.


Takashi