From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB50BC2D0DC for ; Wed, 1 Jan 2020 19:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C407B20722 for ; Wed, 1 Jan 2020 19:17:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727405AbgAATRc (ORCPT ); Wed, 1 Jan 2020 14:17:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:49600 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727268AbgAATRb (ORCPT ); Wed, 1 Jan 2020 14:17:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AAC4CAE8D; Wed, 1 Jan 2020 19:17:29 +0000 (UTC) Date: Wed, 01 Jan 2020 20:17:28 +0100 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: Jaroslav Kysela , , Takashi Iwai , , Subject: Re: [PATCH 02/10] ALSA: ml403-ac97cr: use resource_size In-Reply-To: <1577900990-8588-3-git-send-email-Julia.Lawall@inria.fr> References: <1577900990-8588-1-git-send-email-Julia.Lawall@inria.fr> <1577900990-8588-3-git-send-email-Julia.Lawall@inria.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Jan 2020 18:49:42 +0100, Julia Lawall wrote: > > Use resource_size rather than a verbose computation on > the end and start fields. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > > @@ struct resource *ptr; @@ > - ((ptr->end) - (ptr->start) + 1) > + resource_size(ptr) > > > Signed-off-by: Julia Lawall Unfortunately this doesn't apply cleanly on my tree. I guess you worked on linux-next which contains a change outside the sound git tree that converts ioremap_nocache() to ioremap(). We may apply it in sound git tree and let conflicts resolved at the merge time. OTOH, it's no urgent fix at all and can be postponed after 5.6-rc1 merge, too -- then everything can be applied in a cleaner way. Let me know your preference. thanks, Takashi > > --- > sound/drivers/ml403-ac97cr.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c > index 4e6042e652f0..9de5caaf6047 100644 > --- a/sound/drivers/ml403-ac97cr.c > +++ b/sound/drivers/ml403-ac97cr.c > @@ -1100,9 +1100,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, > PDEBUG(INIT_INFO, "Trying to reserve resources now ...\n"); > resource = platform_get_resource(pfdev, IORESOURCE_MEM, 0); > /* get "port" */ > - ml403_ac97cr->port = ioremap(resource->start, > - (resource->end) - > - (resource->start) + 1); > + ml403_ac97cr->port = ioremap(resource->start, resource_size(resource)); > if (ml403_ac97cr->port == NULL) { > snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": " > "unable to remap memory region (%pR)\n", >