From: Takashi Iwai <tiwai@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] sound updates for 4.19-rc1
Date: Thu, 16 Aug 2018 07:29:17 +0200 [thread overview]
Message-ID: <s5hmutmx4k2.wl-tiwai@suse.de> (raw)
In-Reply-To: <CA+55aFz-+mez2aTqV=Ya9eHC1p+RVrhC_PHZA5ab2x2U+A8GYw@mail.gmail.com>
On Thu, 16 Aug 2018 04:08:04 +0200,
Linus Torvalds wrote:
>
> On Wed, Aug 15, 2018 at 7:05 PM Joe Perches <joe@perches.com> wrote:
> >
> > Why does the commit change snd_hda_gen_add_micmute_led
> > to return 0; instead of return 1;
> >
> > That bit looks wrong.
>
> Well, it changes the comment too, and is clearly intentional.
>
> I guess the logic was to have the usual "0 for success, negative for
> error" logic.
>
> Which is good - but dammit, when you change the return value, you
> should definitely check and update all the callers.
>
> Because yes, updating the call in alc_fixup_dell_wmi() fixes the
> problem for me.
>
> Grr. I wasted a fair amount of time on this.
Doh, sorry for the trouble.
Could you give alsa-info.sh output? Most distros already installed
the script, or it can be taken from
http://www.alsa-project.org/alsa-info.sh
Run the script with --no-upload option and attach the output.
It allows me to run the emulator with your configuration, so I can
debug more certainly.
thanks,
Takashi
prev parent reply other threads:[~2018-08-16 5:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 12:34 [GIT PULL] sound updates for 4.19-rc1 Takashi Iwai
2018-08-15 22:47 ` Linus Torvalds
2018-08-16 1:27 ` Linus Torvalds
2018-08-16 1:48 ` Linus Torvalds
2018-08-16 2:00 ` Linus Torvalds
2018-08-16 2:05 ` Joe Perches
2018-08-16 2:08 ` Linus Torvalds
2018-08-16 5:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmutmx4k2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox