From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96335C4321D for ; Thu, 16 Aug 2018 05:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63D2821480 for ; Thu, 16 Aug 2018 05:29:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63D2821480 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388289AbeHPIZL (ORCPT ); Thu, 16 Aug 2018 04:25:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:34352 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725813AbeHPIZL (ORCPT ); Thu, 16 Aug 2018 04:25:11 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 04B7CACC7; Thu, 16 Aug 2018 05:29:18 +0000 (UTC) Date: Thu, 16 Aug 2018 07:29:17 +0200 Message-ID: From: Takashi Iwai To: Linus Torvalds Cc: Joe Perches , Mark Brown , Liam Girdwood , Linux Kernel Mailing List Subject: Re: [GIT PULL] sound updates for 4.19-rc1 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Aug 2018 04:08:04 +0200, Linus Torvalds wrote: > > On Wed, Aug 15, 2018 at 7:05 PM Joe Perches wrote: > > > > Why does the commit change snd_hda_gen_add_micmute_led > > to return 0; instead of return 1; > > > > That bit looks wrong. > > Well, it changes the comment too, and is clearly intentional. > > I guess the logic was to have the usual "0 for success, negative for > error" logic. > > Which is good - but dammit, when you change the return value, you > should definitely check and update all the callers. > > Because yes, updating the call in alc_fixup_dell_wmi() fixes the > problem for me. > > Grr. I wasted a fair amount of time on this. Doh, sorry for the trouble. Could you give alsa-info.sh output? Most distros already installed the script, or it can be taken from http://www.alsa-project.org/alsa-info.sh Run the script with --no-upload option and attach the output. It allows me to run the emulator with your configuration, so I can debug more certainly. thanks, Takashi