From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B30C43142 for ; Thu, 28 Jun 2018 05:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BB3226E35 for ; Thu, 28 Jun 2018 05:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BB3226E35 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbeF1Fj4 (ORCPT ); Thu, 28 Jun 2018 01:39:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:41940 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbeF1Fjz (ORCPT ); Thu, 28 Jun 2018 01:39:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DF97EADBE; Thu, 28 Jun 2018 05:39:53 +0000 (UTC) Date: Thu, 28 Jun 2018 07:39:52 +0200 Message-ID: From: Takashi Iwai To: "Guy Chronister" Cc: , , "Clemens Ladisch" , "Jaroslav Kysela" , Subject: Re: [PATCH] Fixed typo on line 733. In-Reply-To: <1530125674-11412-1-git-send-email-guylovesbritt@gmail.com> References: <1530125674-11412-1-git-send-email-guylovesbritt@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jun 2018 20:54:34 +0200, Guy Chronister wrote: > > Signed-off-by: Guy Chronister The code change itself is good, but the subject is wrong, and there is no changelog texts. Please describe what it really fixes. It's not about typo fix, but it fixes a real bug, and this has to be written in the subject and explained in more details in the changelog. thanks, Takashi > --- > sound/pci/oxygen/oxygen_mixer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c > index 81af21a..ba87213 100644 > --- a/sound/pci/oxygen/oxygen_mixer.c > +++ b/sound/pci/oxygen/oxygen_mixer.c > @@ -730,7 +730,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl, > oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN); > newreg = oldreg & ~0x0707; > newreg = newreg | (value->value.integer.value[0] & 7); > - newreg = newreg | ((value->value.integer.value[0] & 7) << 8); > + newreg = newreg | ((value->value.integer.value[1] & 7) << 8); > change = newreg != oldreg; > if (change) > oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg); > -- > 2.7.4 > >